Repository navigation
fix(deps): align react-dom with react - #705
Merged
Merged
Conversation
Eyevinn#650 bumped react to ^19.2.7 but left react-dom at ^19.2.3, which the lockfile resolves to 19.2.4. React 19 refuses to run when the two differ: Error: Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got: - react: 19.2.7 - react-dom: 19.2.4 Every test that renders fails on main as a result. before: Test Files 15 failed | 9 passed (24) after: Test Files 24 passed (24) Tests 171 passed Match react-dom's range to react's so the two cannot drift apart again. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
birme
approved these changes
Sep 21, 2026
birme
left a comment
birme
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Fixes a real breakage: react 19.2.7 vs react-dom 19.2.4 mismatch makes React 19 refuse to run, failing every render test on main. Diff is minimal (package.json + lockfile alignment to ^19.2.7), CI green (builds, e2e, lint, prettier). Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#650 bumped react to ^19.2.7 but left react-dom at ^19.2.3, which the lockfile resolves to 19.2.4. React 19 refuses to run when the two differ:
Error: Incompatible React versions: The "react" and "react-dom" packages
must have the exact same version. Instead got:
- react: 19.2.7
- react-dom: 19.2.4
Every test that renders fails on main as a result.
before: Test Files 15 failed | 9 passed (24)
after: Test Files 24 passed (24) Tests 171 passed
Match react-dom's range to react's so the two cannot drift apart again.
Found while rebasing the video-support branch (#684) onto
main. That branch is internallyconsistent at 19.2.4 and so is green today, but it inherits the breakage as soon as its merge
conflict with
mainis resolved.